fix validatator name filter on missed slots#711
Merged
Conversation
mattevans
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show missed slots when filtering by proposer index or name
Summary
shouldCheckMissinggate inChainService.GetDbBlocksByFilterwas disabling reconstruction of missed slots from epoch duties whenever aProposerIndexorProposerNamefilter was set, so the filtered slots view never showed missed slots for a specific validator.filter.ProposerIndex == nil && filter.ProposerName == ""from theshouldCheckMissingcondition so missed slots appear for proposer-filtered queries.Root cause
Both terms were introduced unintentionally during a
master→gloas-supportmerge conflict resolution in128a7f66("Merge branch 'master' into gloas-support", Feb 10 2026). Two diverging tails of theshouldCheckMissingexpression were concatenated and&& filter.ProposerIndex == nil && filter.ProposerName == ""was tacked on, with the whole tail duplicated. The duplication was cleaned up in a later commit, but the bogus proposer terms remained.